Size t dtoh #10862
Merged
Size t dtoh #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @UplinkCoder! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#10862" |
|
This needs a test. |
|
Ah right my bad forgot to add it.
Am Mi., 4. März 2020 um 10:00 Uhr schrieb Nicholas Wilson <
notifications@github.com>:
… This needs a test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10862?email_source=notifications&email_token=AAVWSCCXLS5OEHJX6L3IE33RFYKDTA5CNFSM4LA7VIO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENW5VQI#issuecomment-594401985>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVWSCFO3YIENDF3V2SIAZ3RFYKDTANCNFSM4LA7VIOQ>
.
|
|
@thewilsonator done! |
thewilsonator
approved these changes
Mar 4, 2020
ibuclaw
reviewed
Mar 6, 2020
| @@ -726,8 +729,17 @@ public: | |||
| visit(cast(AST.Dsymbol)ad); | |||
| return; | |||
| } | |||
|
|
|||
| // for function pointers we need to original type | |||
There was a problem hiding this comment.
Sentence seems (incomplete), or missing a bit (in the) middle.
ibuclaw
reviewed
Mar 6, 2020
| @@ -1667,7 +1682,12 @@ public: | |||
| if (i) | |||
| buf.writestring(", "); | |||
| auto fparam = AST.Parameter.getNth(tf.parameterList.parameters, i); | |||
| if (fparam.type == AST.Type.tsize_t && originalType) | |||
There was a problem hiding this comment.
I suspect this comparison to size_t will need to be turned into a function.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should treat
size_tas a special alias and emit it