Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] Check in iasmgcc.c implementation #10916

Merged
merged 3 commits into from
Mar 14, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Mar 14, 2020

And backport recent parser fixes.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
20592 major [GCC ASM] [ICE] dmd/iasmgcc.d(332): Assertion failure
20593 normal [GCC ASM] Parser syntax for asm operands differs from GCC

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "dmd-cxx + dmd#10916"

@ibuclaw ibuclaw merged commit b061bd7 into dlang:dmd-cxx Mar 14, 2020
@ibuclaw ibuclaw deleted the dmd-cxx-iasmgcc branch March 14, 2020 17:48
kraj pushed a commit to kraj/gcc that referenced this pull request Mar 16, 2020
Fixes an ICE in the parser, and deprecates a previously allowed style of
syntax that deviated from GNU-style extended asm.

Reviewed-on: dlang/dmd#10916

gcc/testsuite/ChangeLog:

2020-03-16  Iain Buclaw  <ibuclaw@gdcproject.org>

	* gdc.dg/asm1.d: Add new test for ICE in asm parser.
	* gdc.dg/asm5.d: New test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants