Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20643 - printf without arguments aborts compilation #10921

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented Mar 14, 2020

We shouldn't return an error, because it is deprecated for the moment.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20643 minor printf without arguments aborts compilation

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10921"

@Luhrel Luhrel changed the title Issue 20643 - printf without arguments aborts compilation Fix Issue 20643 - printf without arguments aborts compilation Mar 14, 2020
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a compilable test

@Luhrel Luhrel force-pushed the fix20643 branch 4 times, most recently from 71e8188 to 8f5e037 Compare March 15, 2020 14:28
@thewilsonator thewilsonator merged commit d24250e into dlang:master Mar 16, 2020
@Luhrel Luhrel deleted the fix20643 branch March 16, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants