Fix issue 19949: Implement support for C++ ABI tags #10927

Geod24 · 2020-03-15T23:22:28Z

Implements C++ ABI tags with a few more restriction than the previous PR (9995).
In particular, do not follow C++ source-level conventions when impractical
(e.g. propagation). Since this is a feature that will be seldom used by users,
I favored implementation simplicity over user-friendly semantics.

Previous PR by @SSoulaimane : #9995
Since the author has gone AWOL and there were some discussions on the initial PR, I had a go at implementing it. I mostly used the tests from the original PR, which were very comprehensive, but tried to keep the special casing in semantic to a minimum.
Requires dlang/druntime#2990 to pass tests.

dlang-bot · 2020-03-15T23:22:31Z

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19949	normal	C++ Mangling: no support for abi-tags from the Itanium ABI

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10927"

thewilsonator · 2020-03-16T00:15:55Z

restruction? Restriction?

src/dmd/semantic2.d

src/dmd/cppmangle.d

Geod24 · 2020-03-16T05:31:33Z

So on OSX, the compiler is too old:

HOST_CXX (c++): Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin13.4.0
Thread model: posix

From a quick Google, only LLVM 3.9 knows about ABI tags.
3.9 was release 2016-09-02, 3.5.0 was released 2014-01-02 and 3.5.2 was released 2015-04-02.

I tested it on my machine, it works, but there's no way to test it on the auto-tester.

Geod24 · 2020-03-17T05:25:13Z

Okay that's not going to work. Maybe it's time to have another CI provider run the C++ interop tests.

MoonlightSentinel · 2020-03-17T10:41:50Z

Okay that's not going to work. Maybe it's time to have another CI provider run the C++ interop tests.

Or manually let the test suite fetch a more recent clang if necessary?

test/runnable/cpp11.d

Geod24 · 2020-03-25T03:58:11Z

Okay that's not going to work. Maybe it's time to have another CI provider run the C++ interop tests.

#10964

src/dmd/semantic2.d

The mangling issues have long been resolved, and osx32 has been dropped.

This should make our life so much simpler.

posix.mak

test/compilable/cpp_abi_tag_unused.d

MoonlightSentinel · 2020-03-27T12:33:17Z

test/tools/d_do_test.d

+ */
+void printCppSources (in const(char)[][] compiled)
+{
+    version (Posix)


The windows machines have some ported Posix utilities AFAICT (e.g. bash). Might be worth to try nm and silently ignore failures on windows.

Geod24 · 2020-03-27T13:50:08Z

Runnable_cxx also needs to be disabled on semaphore ci because it uses GCC 4.8.4

This is now handled by Github actions. Don't disable Windows because this hasn't been implemented yet.

…nium ABI Implements C++ ABI tags with a few more restriction than the previous PR (9995). In particular, do not follow C++ source-level conventions when impractical (e.g. propagation). Since this is a feature that will be seldom used by users, I favored implementation simplicity over user-friendly semantics. Co-Authored-By: سليمان السهمي (Suleyman Sahmi) <sahmi.soulaimane@gmail.com>

Geod24 · 2020-03-27T20:57:23Z

Green at last 🎉

Geod24 · 2020-03-28T07:18:20Z

Hum, this went red for Ubuntu after merge... Will fix.

Geod24 · 2020-03-28T11:55:13Z

Fix being worked on here: #10974

Geod24 requested a review from ibuclaw as a code owner March 15, 2020 23:22

dlang-bot added the Severity:Bug Fix label Mar 15, 2020

Geod24 mentioned this pull request Mar 15, 2020

Add compiler-recognized UDA for Itanium ABI's abi-tags dlang/druntime#2990

Merged

thewilsonator reviewed Mar 16, 2020

View reviewed changes

src/dmd/semantic2.d Show resolved Hide resolved

src/dmd/cppmangle.d Outdated Show resolved Hide resolved

Geod24 force-pushed the cpp_abi_tag branch 3 times, most recently from b0f3ae0 to a361021 Compare March 17, 2020 05:12

MoonlightSentinel reviewed Mar 17, 2020

View reviewed changes

test/runnable/cpp11.d Outdated Show resolved Hide resolved

Geod24 force-pushed the cpp_abi_tag branch from a361021 to 09b5457 Compare March 23, 2020 07:07

Geod24 mentioned this pull request Mar 25, 2020

Add a Github action file to test runnable_cxx #10964

Merged

Geod24 added the Merge:Blocked label Mar 25, 2020

ibuclaw reviewed Mar 25, 2020

View reviewed changes

src/dmd/semantic2.d Show resolved Hide resolved

Geod24 removed the Merge:Blocked label Mar 27, 2020

Geod24 added 2 commits March 27, 2020 13:42

Remove cpp_stdlib outdated comment

314ebcf

The mangling issues have long been resolved, and osx32 has been dropped.

d_do_test: Run nm on C++ objects on failure

848824a

This should make our life so much simpler.

Geod24 force-pushed the cpp_abi_tag branch 4 times, most recently from 30ba5cf to 700d467 Compare March 27, 2020 09:27

Geod24 requested review from MartinNowak and wilzbach as code owners March 27, 2020 09:27

MoonlightSentinel reviewed Mar 27, 2020

View reviewed changes

posix.mak Outdated Show resolved Hide resolved

Geod24 force-pushed the cpp_abi_tag branch from 0ba6a01 to f565a10 Compare March 27, 2020 12:18

MoonlightSentinel reviewed Mar 27, 2020

View reviewed changes

test/compilable/cpp_abi_tag_unused.d Outdated Show resolved Hide resolved

MoonlightSentinel reviewed Mar 27, 2020

View reviewed changes

Geod24 force-pushed the cpp_abi_tag branch from f565a10 to 3806eac Compare March 27, 2020 12:48

Geod24 and others added 2 commits March 28, 2020 05:09

Disable runnable_cxx on POSIX's auto-tester

c6c14a1

This is now handled by Github actions. Don't disable Windows because this hasn't been implemented yet.

Geod24 force-pushed the cpp_abi_tag branch from 3806eac to 45bc423 Compare March 27, 2020 20:09

thewilsonator approved these changes Mar 28, 2020

View reviewed changes

thewilsonator added the Merge:auto-merge label Mar 28, 2020

thewilsonator merged commit 371de31 into dlang:master Mar 28, 2020

Geod24 deleted the cpp_abi_tag branch March 28, 2020 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue 19949: Implement support for C++ ABI tags #10927

Fix issue 19949: Implement support for C++ ABI tags #10927

Geod24 commented Mar 15, 2020 •

edited

Loading

dlang-bot commented Mar 15, 2020

thewilsonator commented Mar 16, 2020

Geod24 commented Mar 16, 2020

Geod24 commented Mar 17, 2020

MoonlightSentinel commented Mar 17, 2020

Geod24 commented Mar 25, 2020

MoonlightSentinel Mar 27, 2020

Geod24 commented Mar 27, 2020

Geod24 commented Mar 27, 2020

Geod24 commented Mar 28, 2020

Geod24 commented Mar 28, 2020

Fix issue 19949: Implement support for C++ ABI tags #10927

Fix issue 19949: Implement support for C++ ABI tags #10927

Conversation

Geod24 commented Mar 15, 2020 • edited Loading

dlang-bot commented Mar 15, 2020

Bugzilla references

Testing this PR locally

thewilsonator commented Mar 16, 2020

Geod24 commented Mar 16, 2020

Geod24 commented Mar 17, 2020

MoonlightSentinel commented Mar 17, 2020

Geod24 commented Mar 25, 2020

MoonlightSentinel Mar 27, 2020

Choose a reason for hiding this comment

Geod24 commented Mar 27, 2020

Geod24 commented Mar 27, 2020

Geod24 commented Mar 28, 2020

Geod24 commented Mar 28, 2020

Geod24 commented Mar 15, 2020 •

edited

Loading