fix issue 20675 - dip1000 improper error about copying scope paramete…

[aG0aep6G]

…r into allocated memory

@WalterBright, you probably want to have a look.

[dlang-bot]

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20675	normal	dip1000 improper error about copying scope parameter into allocated memory

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10929"

[WalterBright]

Ya beat me to it :-) and it seems we came up with the same solution. Anyhow, the test case is excessive. It should be appended to test/compilation/scope.d and consist of merely:

// https://issues.dlang.org/show_bug.cgi?id=20675

struct D
{
    int pos;
    char* p;
}

void test(scope ref D d) @safe
{
    D[] da;
    da ~= D(d.pos, null);
}

This will make the incremental test time insignificant compared with making an executable.

[WalterBright]

see comment

[aG0aep6G]

Anyhow, the test case is excessive. It should be appended to test/compilation/scope.d

done

[aG0aep6G]

Similar bug and fix: #10935

Tests adjusted