fix issue 20653 . Short circuit manifest constant evaluation

[benjones]

The fix is adding the SCOPE.condition flag when doing CTFE to infer the VarDecl type in dsymbolsem.

The rest of the changes are fixes to the debug logging. I can remove them if they're distracting

[WalterBright]

Please explain the point of this. Is it a bug fix? An enchancement?

[thewilsonator]

Is it a bug fix?

fix issue 20653

Dunno where the bot is though.

[thewilsonator]

The rest of the changes are fixes to the debug logging. I can remove them if they're distracting

Can you split them into a different commit?

[benjones]

I started this as a draft PR, so maybe @dlang-bot didn't notice when I dropped the draft.

I'll split into 2 commits. I'll also add a test with &&

[dlang-bot]

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20653	normal	Short-circuiting boolean logic not working

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10939"

[Geod24]

Could you add a test with a template instantiation ?
Something like:

T myFunc() { return T.init; }
enum Foo(T) = is(T == int) || myFunc!T();

void main ()
{
    assert(myFunc!int() == 0);
}

The idea is to check that myFunc!int is properly emitted and does not cause linking error.

[TurkeyMan]

Dunno where the bot is though.

I mean, cheeky bugger's probably self-isolating!

[WalterBright]

cheeky bugger's

I can't let you Aussies have a monopoly on cool phrases. It's not fair!

[TurkeyMan]

😛

[MoonlightSentinel]

Could you add a test with a template instantiation ?
Something like: [...]
The idea is to check that myFunc!int is properly emitted and does not cause linking error.

Could also add this to the compilable test and force linking with

// LINK:

[ntrel]

@benjones This breaks the error for is Identifier forms used outside of static if/assert:
https://issues.dlang.org/show_bug.cgi?id=23827

I tried making a fix but it doesn't pass the test suite.

[benjones]

I saw your new PR. It's been so long, I don't remember how I came to think this was the right fix and probably won't have time to look closely in the next couple of weeks.