Fix Issue 20696 - Should error when retrieving mangling while the typ… #10961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#10961" |
WalterBright
force-pushed
the
fix20696
branch
3 times, most recently
from
6e9f57a to
9983eda
Compare
…e is not yet final
RazvanN7
reviewed
Mar 26, 2020
| @@ -11399,6 +11399,12 @@ Expression semanticX(DotIdExp exp, Scope* sc) | |||
| { | |||
| return new ErrorExp(); | |||
| } | |||
| if (f.flags & (FUNCFLAG.purityInprocess | FUNCFLAG.safetyInprocess | | |||
There was a problem hiding this comment.
I think that this will not catch nested functions:
void func(T)
{
void foo()
{
pragma(msg, foo.mangleof);
}
}
|
What about @RazvanN7 's review: #10961 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e is not yet final