recognize assigning .init of all zeros, replace with memset #10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#10967" |
WalterBright
force-pushed
the
initZero
branch
5 times, most recently
from
426f24f to
f508a38
Compare
n8sh
reviewed
Mar 28, 2020
Comment on lines
+3146
to
+3142
| if ((sle.useStaticInit || | ||
| sle.elements && allZeroBits(*sle.elements) && !sle.sd.isNested()) && | ||
| ae.e2.type.isZeroInit(ae.e2.loc)) |
There was a problem hiding this comment.
Should this be
(sle.useStaticInit && ae.e2.type.isZeroInit(ae.e2.loc))
||
(sle.elements && allZeroBits(*sle.elements) && !sle.sd.isNested())?
There was a problem hiding this comment.
no because sle.elements does not include default initializers.
WalterBright
force-pushed
the
initZero
branch
2 times, most recently
from
2907d00 to
02962c5
Compare
So I click for "Details", and there are no details, no log, just it failed. |
|
Does this include init with void gaps ?, e.g because in this case the gap can be ignored and filled with 0 as well. |
|
Looks like the C++ heisenbug disappeared. |
atilaneves
approved these changes
Jun 11, 2020
|
@atilaneves wunderbar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structs are often initialized or assigned values of all 0 bits. This usually results in copying the
.initglobal into the struct. This PR recognizes some of those cases and replaces them withmemset'ing them to zero. This is faster, and a step towards eliminating the.initglobal altogether.