Fix issue 20444 - Support SOURCE_DATE_EPOCH for reproducible builds
#11035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
requested review from
ibuclaw,
MartinNowak,
rainers and
WalterBright
as code owners
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11035" |
Geod24
force-pushed
the
source-date-epoch
branch
from
c1c3acf to
ddef3ed
Compare
Geod24
force-pushed
the
source-date-epoch
branch
from
ddef3ed to
4ab95db
Compare
WebFreak001
reviewed
Apr 14, 2020
Geod24
force-pushed
the
source-date-epoch
branch
from
4ab95db to
42096e1
Compare
|
Rebased on master, fixed the styling error, applied @WebFreak001 's suggestion. |
Geod24
force-pushed
the
source-date-epoch
branch
from
42096e1 to
f06d8dc
Compare
Instead of having those `__gshared` constant hiddent in the middle of a very long function, move them to a struct and add documentation.
Geod24
force-pushed
the
source-date-epoch
branch
from
f06d8dc to
f67c53a
Compare
Adds support for the de-facto standard `SOURCE_DATE_EPOCH` variable, for lexer tokens `__DATE__`, `__TIME__`, `__TIMESTAMP__`.
Geod24
force-pushed
the
source-date-epoch
branch
from
f67c53a to
bfb538a
Compare
|
Moving things to target was a terrible idea. I changed that now, the PR should be much simpler. |
|
Ping ? |
|
Awesome to see this PR! I tried to build dmd 2.09 with this PR but it doesn't seem compatible. I'll check if it's do-able to build master on Arch. |
|
Works perfectly for me. Checked on Linux, amd64, with dmd v2.092.0. Thanks! |
|
I missed this PR, thanks a lot @Geod24! On less thing to worry about when building D code on NixOS ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this PR touches a bunch of unrelated things, I'll split it into multiple PRs, this PR is solely to show the end goal.CC @jelly : Can you check the last commit ?
CC @ibuclaw , you might be interested in this.