Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 20780: Function parameter UDA not accepted in nested function declarations #11086

Merged
merged 2 commits into from
May 3, 2020
Merged

Fix issue 20780: Function parameter UDA not accepted in nested function declarations #11086

merged 2 commits into from
May 3, 2020

Conversation

benjones
Copy link
Contributor

@benjones benjones commented May 1, 2020 •
edited by Geod24
Loading

Patch provided by Basile-z on Bugzilla.
I believe he's not on github, but posted this patch to bugzilla.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 20780 normal Function parameter UDA not accepted in nested function declarations

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11086"

@benjones
Copy link
Contributor Author

benjones commented May 3, 2020

@thewilsonator The bot took off auto merge bc I force pushed to give basile credit, but the code is the same as what you approved.

@Geod24 Geod24 changed the title fix issue 20780 PR for the patch written by Basile-Z Fix issue 20780: Function parameter UDA not accepted in nested function declarations May 3, 2020
Geod24
Geod24 reviewed May 3, 2020
View reviewed changes
src/dmd/parse.d Show resolved Hide resolved
@Geod24 Geod24 merged commit 2d5c30e into dlang:master May 3, 2020
rainers pushed a commit to rainers/dmd that referenced this pull request May 17, 2020
@benjones @Lars-Kristiansen @rainers
Fix issue 20780: Function parameter UDA not accepted in nested functi…
eaa16ce 
…on declarations (dlang#11086)

Patch submitted by Basile-z on Bugzilla.

Co-authored-by: Basile Burg <basile.b@gmx.com>
@benjones benjones deleted the fix20780 branch May 19, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@Geod24 Geod24 Geod24 approved these changes

Assignees
No one assigned
Labels
Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjones @dlang-bot @Geod24 @thewilsonator @Lars-Kristiansen