Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20791 - extern(C++ <strings>) should allow a trailing comma #11090

Merged
merged 1 commit into from
May 2, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented May 1, 2020

This inconsistency was also mentioned in the spec PR

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20791 enhancement extern(C++ ) should allow a trailing comma

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11090"

@dlang-bot dlang-bot merged commit 5c896f1 into dlang:master May 2, 2020
@WalterBright
Copy link
Member

Grammar PR for this change?

@WalterBright
Copy link
Member

Also, do not make grammar changes to the language without my approval. Thanks.

@MoonlightSentinel MoonlightSentinel deleted the extern-comma branch May 2, 2020 18:35
@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented May 2, 2020

Grammar PR for this change?

This feature isn't even documented yet because the spec PR got blocked. @Geod24 is currently investigating that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants