Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20795 - [dip1000] segfault on templated opEquals #11096

Merged
merged 1 commit into from May 4, 2020

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented May 4, 2020

sc.func is null when trying to call setUnsafe.

What puzzles me is that sc.func is used throughout the whole function without any checks. This makes me wonder if the check should be added at the start of the function.

@dlang-bot
Copy link
Contributor

dlang-bot commented May 4, 2020

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20795 normal [dip1000] segfault on templated opEquals

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11096"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this target stable?

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented May 4, 2020

Bah, I always forget that....

Done.

@RazvanN7 RazvanN7 changed the base branch from master to stable May 4, 2020 10:44
@thewilsonator thewilsonator merged commit 8456a52 into dlang:stable May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants