Fix issue 20796: package protected symbol declared in the same packag…

[thewilsonator]

…e.d don't work

N.B I'm unsure if I need to do anything special to ensure that the test runs, given it is in a subfolder. cc @MoonlightSentinel hopefully you know.

[dlang-bot]

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20796	enhancement	protection attribute package(x.y) does not bind to one of ancestor packages of module x.y when declared in x/y/package.d

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11100"

[ibuclaw]

Before I'll do anything, let me reread the spec again.

I remember hitting some problem with package() in the past when doing a POC for std.math.package, but the spec matched the error (albeit, initially surprisingly, but made sense after some thought).

Can't remember any more details, but you may have stumbled on the same thing I encountered.

[ibuclaw]

OK, I see it is a bug. :-)

[thewilsonator]

Was that supposed to be an approval? You requested changes.

[ibuclaw]

Needs test.

[thewilsonator]

There is one ;) I'm not sure it being run though.

[ibuclaw]

@thewilsonator

compilable/test20796.d:

// EXTRA_SOURCES: extra-files/issue20796/package.d
// https://issues.dlang.org/show_bug.cgi?id=20796

compilable/extra-files/issue20796/package.d

[your test here]

[thewilsonator]

Done.

[ibuclaw]

@thewilsonator you forgot to move the test file to its proper location.

[thewilsonator]

whoops.