Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 16971 - Misleading error messages... #11121

Merged
merged 1 commit into from
May 9, 2020

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented May 9, 2020

..."break is not inside scope(exit) bodies" "continue is not inside scope(exit) bodies"

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16971 trivial Misleading error messages "break is not inside scope(exit) bodies" "continue is not inside scope(exit) bodies"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11121"

@thewilsonator
Copy link
Contributor

Please update the tests.

@dlang-bot dlang-bot merged commit 5fdbca2 into dlang:master May 9, 2020
@acehreli
Copy link

acehreli commented May 9, 2020

Thank you fixing these. However, a neighboring test shows that for consistency, the messages could be in the form of "... statements cannot be in scope(exit) bodies". Oh well, nobody will know... :)

@Luhrel Luhrel deleted the fix16971 branch May 24, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants