Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 16181 - Overloading doesn't consider default arguments with… #11127

Closed
wants to merge 1 commit into from

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented May 10, 2020

… regards to ambiguity

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16181 minor Overloading doesn't consider default arguments with regards to ambiguity

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11127"

@kubo39
Copy link
Contributor

kubo39 commented May 11, 2020

should it be deprecation?

}

if (!bypass)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: c1 and c2 can be moved here.

@WalterBright
Copy link
Member

It is not a bug and the compiler is behaving as designed.

@WalterBright
Copy link
Member

Sorry.

@Luhrel Luhrel deleted the fix16181 branch May 24, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants