Fix Issue 20626 - ICE when using typeof of unittest symbol without -u…

[MoonlightSentinel]

…nittest flag.

Not sure if this is the behaviour but the special unittest functions should not be used in user code anyway.

[dlang-bot]

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20626	regression	ICE when using typeof of unittest symbol without -unittest flag

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11145"

[MoonlightSentinel]

CC @Geod24

[Geod24]

This seems rather specialized, no ? I would look into what's happening with in / out contracts and perhaps invariant, to see if the problem is tied to unittest or not. It could be a general fwd ref error which triggers with all those maybe-instantiated symbols, or it could be something specific to unittest (since it's the only symbol that would not be parsed when unused, AFAIK).

[MoonlightSentinel]

The problem here is that the UnitTestDeclaration is barely initialized because the unittest is ignored. That is different from contracts which are analyzed even if they are not used.

Anyhow, I'll add a test for ignored invariants.

[Geod24]

Thanks, LGTM

[UplinkCoder]

This is a bit dubious.
There are deeper issues here.