Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20825: paths in error messages from build.d should be click… #11157

Merged
merged 1 commit into from May 19, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented May 18, 2020

…able.

Just to improve the current development process.

Before:

[...]
-----------------------------------------------------------
ERROR: dmd/expression.d(763): Error: undefined identifier `xxx`

After:

[...]
-----------------------------------------------------------
ERROR: src/dmd/expression.d(763): Error: undefined identifier `xxx`

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20825 normal the filename of the error messages generated by dmd build.d script miss the "src/" part of the path

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11157"

@Geod24
Copy link
Member

Geod24 commented May 19, 2020

Note that clickable for one is not clickable for the other... It always baffled me that the makefiles were in src, so I always assumed it was Walter's working directory.

@dlang-bot dlang-bot merged commit 4dae617 into dlang:master May 19, 2020
@MoonlightSentinel MoonlightSentinel deleted the build-error branch May 19, 2020 07:20
@MoonlightSentinel
Copy link
Contributor Author

Always thought that it was just a common pattern to split responsibilities in nested Makefiles.

But I can always make this optional if it causes problems for other people.

@Geod24
Copy link
Member

Geod24 commented May 19, 2020

No the one in src predates posix.mak by a long shot. I've seen quite a lot of old projects doing this.

In any case I'm very happy with the change, let's see if someone complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants