Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 12520 - allow comparison of empty tuples to tuples that con… #11187

Merged
merged 1 commit into from May 25, 2020
Merged

fix issue 12520 - allow comparison of empty tuples to tuples that con… #11187

merged 1 commit into from May 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2020

…tain values

Empty tuples are represented as TypeTuple while tuples containing values as TupleExp.
As a consequence, comparing them using == was not allowed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
12520 normal Comparing two TypeTuples with == does not compile for no arguments

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11187"

src/dmd/expressionsem.d Outdated Show resolved Hide resolved
…tain values

Empty tuples are represented as `TypeTuple` while tuples containing values as `TupleExp`.
As a consequence, comparing them using `==` was not allowed.
@dlang-bot dlang-bot merged commit e476147 into dlang:stable May 25, 2020
@ghost ghost deleted the issue-12520 branch May 25, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants