Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20890 - parameter corruption when other parameter is a stat… #11207

Merged
merged 1 commit into from Jun 2, 2020
Merged

fix issue 20890 - parameter corruption when other parameter is a stat… #11207

merged 1 commit into from Jun 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2020

…ic array of length 1

Note that this fix is rather empirical. The code added in #9357 only works when the element of the array of length 1 has a sizeof that is > 1, otherwise that corrupted the other parameters (apparently).

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20890 regression parameter corruption when other parameter is a static array of length 1

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11207"

@dlang-bot dlang-bot merged commit ac3d206 into dlang:stable Jun 2, 2020
@ghost ghost deleted the issue-20890 branch June 2, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants