Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 20903 - seg fault on long signed divide overflow #11244

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
20903 major seg fault on long signed divide overflow

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11244"

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go directly in the stable branch.

@WalterBright
Copy link
Member Author

Blocking #11236

@WalterBright WalterBright added the Review:Blocking Other Work review and pulling should be a priority label Jun 7, 2020
@UplinkCoder
Copy link
Member

@WalterBright can you target stable?

@WalterBright
Copy link
Member Author

No, because it is not a regression, and I need it for the PR it is blocking.

@UplinkCoder
Copy link
Member

@WalterBright go ahead and self-merge then.
This is harmless as far as I can see.

@dlang-bot dlang-bot merged commit 9c8e7bb into dlang:master Jun 7, 2020
@WalterBright WalterBright deleted the fix20903 branch June 7, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants