Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20915 - exclude version and debug identifier from __traits(allMembers) results #11260

Merged
merged 1 commit into from Jun 11, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2020

This is the right fix this time, after clarification from @WalterBright on the semantics.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20915 major __traits(allMembers) results include custom version identifiers, which is unusable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11260"

@ghost ghost requested a review from ibuclaw as a code owner June 10, 2020 23:45
Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use either Condition or DVCondition ?

@ghost
Copy link
Author

ghost commented Jun 11, 2020

Using VersionSymbol and DebugSymbol there's no need to test the identifier in the table of identifiers attached to the module. The code to cast a result to a symbol is already there, just a little isStuff isThing and it's good. That's a completly straightforward way of filtering out the problematic things.

@ghost ghost requested a review from Geod24 June 11, 2020 04:16
@ghost ghost requested a review from Geod24 June 11, 2020 05:30
@WalterBright
Copy link
Member

It took me a moment to figure out why the version and debug ids were even showing up in allMembers. Turns out it was inadvertent and they should be excluded. This PR looks good.

@dlang-bot dlang-bot merged commit b2ead32 into dlang:master Jun 11, 2020
@ghost ghost deleted the issue-20915 branch June 11, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants