Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20833 - Template members prevent __traits(getOverloads) from working properly #11295

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

rmanthorpe
Copy link
Contributor

@rmanthorpe rmanthorpe commented Jun 18, 2020

There was no handling for DotTemplateExpressions so declaring a template overload before a regular overload prevented it from finding any overloads.

Fixes a regression introduced by #8195.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 18, 2020

Thanks for your pull request and interest in making D better, @rmanthorpe! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20833 regression Template members prevent __traits(getOverloads) from working properly

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11295"

@rmanthorpe rmanthorpe changed the base branch from master to stable June 18, 2020 10:32
@dlang-bot dlang-bot merged commit 05eb65e into dlang:stable Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants