fix Issue 18748 - bt instruction with immediate offset uses 64-bit va… #11305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11305" |
WalterBright
force-pushed
the
fix18748
branch
2 times, most recently
from
82b90fd
to
aca2ea4
Compare
Geod24
reviewed
Jun 25, 2020
test/runnable/testbtst.d
Outdated
Comment on lines
140
to
145
| /+ | ||
| enum shift = uint.max + 1L; | ||
| assert(cast(uint) shift == 0); | ||
| ulong s = 1; | ||
| assert(g(&s, shift)); | ||
| +/ |
There was a problem hiding this comment.
that's from another fix that wasn't merged yet.
There was a problem hiding this comment.
I merged it yesterday, this needs a rebase.
…riant for 32-bit data
andralex
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…riant for 32-bit data