Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7021 - Structs with disabled default constructors can be constructed without calling a constructor. #1132

Merged
merged 1 commit into from
Oct 11, 2012

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Sep 21, 2012

@9rnsr
Copy link
Contributor Author

9rnsr commented Sep 21, 2012

I've changed the original issue number from 8703 to 7021, because 8703 was just a dup of 7021.

@nazriel
Copy link
Contributor

nazriel commented Oct 5, 2012

Looks good to me 👍
Also old red test results seems to not be related with this pull request.

@andralex
Copy link
Member

Please rebase. What happens when one tries to create an array or a member variable? I assume that won't work, which is fine at least for now.

@9rnsr
Copy link
Contributor Author

9rnsr commented Oct 11, 2012

Rebased.

@andralex
Copy link
Member

I'll go on a limb and merge this in.

andralex added a commit that referenced this pull request Oct 11, 2012
Issue 7021 - Structs with disabled default constructors can be constructed without calling a constructor.
@andralex andralex merged commit 3038cf1 into dlang:master Oct 11, 2012
@9rnsr
Copy link
Contributor Author

9rnsr commented Oct 11, 2012

Wow, is this your first commit to the dmd repository?

@andralex
Copy link
Member

The second I think :o).

@ghost
Copy link

ghost commented Oct 11, 2012

How will this interact with an enabled static opCall? The opCall probably shouldn't work if there is a disabled ctor, but we should probably verify this in a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants