Fix Issue 20989 - Checking array.ptr causes safety error ...

[MoonlightSentinel]

... with -checkaction=context.

Explicity flag DotIdExpressions as noderef because _d_assert_fail will not dereference the pointer and thus make the call @safe.

[dlang-bot]

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20989	minor	Checking array.ptr causes safety error with -checkaction=context

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11337"

[Geod24]

Nice!

[ghost]

Sorry, little off-topic, this PR is nice but what has happened to our codecov check ?

[ibuclaw]

Sorry, little off-topic, this PR is nice but what has happened to our codecov check ?

It's still being pushed by the circleci pipeline.

[nordlow]

BTW, compiling

pure unittest
{
    int[] x;
    assert(x.ptr);
}

with -checkaction=context and running the test only prints

foo.d(4): [unittest] assert(x.ptr) failed

Wouldn't it be nice to print the value of x.ptr in this case?

[MoonlightSentinel]

Wouldn't it be nice to print the value of x.ptr in this case?

Indeed, thats why I've recently added support for unary expressions. It should be included in 2.093.0.

.\generated\windows\debug\64\dmd.exe -checkaction=context -main -unittest -run pretty_assert.d
pretty_assert.d(6): [unittest] 0x0 != true
....

[MoonlightSentinel]

This is ready for another review.