fix issue 20761 - __traits(isSame) for alias tuples is broken and und…

[ghost]

…erspecified

[dlang-bot]

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20761	major	__traits(isSame) for alias tuples is broken and underspecified

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11373"

[ghost]

This good now. All previous fixes made to isSame are applied to individual tuple elements.

[MoonlightSentinel]

Mssing #11373 (comment) but otherswise LGTM

Pending changes

[MoonlightSentinel]

Thanks

[ghost]

alright, I'm no longer answerable for anything now.

[ghost]

label's gone again

[wilzbach]

Why did no one ask for a test to be added? Tests should be the bare minimum!!

[MoonlightSentinel]

Because the original version had tests which apparenty got lost during the commit partitioning (and I'm blind as well).

Added some tests in #11392

[ghost]

test got lost here

NilsLankila force-pushed the NilsLankila:issue-20761 branch from 6f79913 to a637577 7 hours ago