Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 12490 - No "Error: , has no effect" Error for comma expression LHS #11377

Merged
merged 1 commit into from Jul 14, 2020
Merged

fix issue 12490 - No "Error: , has no effect" Error for comma expression LHS #11377

merged 1 commit into from Jul 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2020

Following a comment in sideeffect.d on how to check the LHS.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
12490 normal No "Error: , has no effect" Error for comma expression LHS

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11377"

src/dmd/sideeffect.d Outdated Show resolved Hide resolved
…ion LHS

Following a comment in sideeffect.d on how to check the LHS.
@ghost
Copy link
Author

ghost commented Jul 14, 2020

ping

@dlang-bot dlang-bot merged commit 7f52672 into dlang:master Jul 14, 2020
@ghost ghost deleted the issue-12490 branch July 14, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants