Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21019 - Replace rm with rm_retry in shell scripts #11380

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Jul 6, 2020

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21019 normal Azure pipelines Windows_VisualD win32-ldc fails with Heisenbug

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11380"

@@ -1,6 +1,8 @@
#!/usr/bin/env bash

source tools/common_funcs.sh
Copy link
Contributor Author

@MoonlightSentinel MoonlightSentinel Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly sourceing for every POSTSCRIPT isn't pretty but they will be replaced anyway in the near future.

@WalterBright
Copy link
Member

Thanks!

@dlang-bot dlang-bot merged commit c8d460c into dlang:master Jul 6, 2020
@MoonlightSentinel MoonlightSentinel deleted the rm_retry branch July 6, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants