Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue 20761 - __traits(isSame) for alias tuples... #11392

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

... is brokenand underspecified.

The original tests from #11373 got lost.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20761 major __traits(isSame) for alias tuples is broken and underspecified

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11392"

@ghost
Copy link

ghost commented Jul 8, 2020

can you add a test with varsious combination of nested AliasSeq ? e.g

AliasSeq!(0,AliasSeq!(1,2)) compared to AliasSeq!(0,1,2)) for example

test/compilable/traits.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit db5b58c into dlang:master Jul 9, 2020
@MoonlightSentinel MoonlightSentinel deleted the tests branch June 20, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants