merge stable #11400
Merged
merge stable #11400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Jul 9, 2020
MartinNowak
commented
- Fix 20014: Make -{preview|revert|transition}=all work again
- Fix Issue 20909 - .offsetof fails on forward reference of field
- Fix Issue 20989 - Checking array.ptr causes safety error ...
- bump VERSION to v2.093.0
- purge changelog
The code was probably changed at some point from a break to a return, but the 'all' special case was not updated. For clarity, some text was also edited: 'id' has been renamed to 'name', as 'id' has been used in the past to mean number, and it's also used this way for -version and -debug. Finally, the description for 'all' was fixed.
... with -checkaction=context. Explicity flag `DotIdExpressions` as `noderef` because `_d_assert_fail` will not dereference the pointer and thus make the call `@safe`.
MartinNowak
requested review from
Geod24,
rainers and
WalterBright
as code owners
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11400" |
ibuclaw
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.