fix Issue 21037 - AVX code sometimes fails to set VEX prefix #11406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
@WalterBright it's using The auto-tester boxes claim to be CPU.avx, for instance, so it seems that none of the AVX2 code is properly checked. |
|
@thewilsonator the tests are already in |
ibuclaw
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why that
ifwas there, looking back to the commit that introduced it offers no clue. I don't know why testxmm.d wasn't failing before, perhaps the tests suddenly started running with avx enabled?Anyhow, the test is in
testxmm.d.