Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 20422 - confusing error "new can only create structs, dynamic arrays or class objects, not int[]'s" #11428

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

VladNastase
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 18, 2020

Thanks for your pull request and interest in making D better, @VladNastase! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20422 minor confusing error "new can only create structs, dynamic arrays or class objects, not int[]'s"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11428"

@thewilsonator
Copy link
Contributor

Please squash the commits and title the commit message as "Fix issue 20422 - confusing error "new can only create structs, dynamic arrays or class objects, not int[]'s" and this should be good to go.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend inverting the condition:

if (!narg)
{
    // ...
    return setError();
}
// Code without else

This makes the code more readable, as you get the error cases "out of the way".

else
{
// https://issues.dlang.org/show_bug.cgi?id=20422
// Without this check the compiler would give a missleading error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misleading

@VladNastase
Copy link
Contributor Author

I'd recommend inverting the condition:

if (!narg)
{
    // ...
    return setError();
}
// Code without else

This makes the code more readable, as you get the error cases "out of the way".

Done! Thanks for the suggestion!

@RazvanN7 RazvanN7 merged commit 02b8591 into dlang:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants