-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue 20422 - confusing error "new can only create structs, dynamic arrays or class objects, not int[]'s" #11428
Conversation
|
Thanks for your pull request and interest in making D better, @VladNastase! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11428" |
|
Please squash the commits and title the commit message as "Fix issue 20422 - confusing error "new can only create structs, dynamic arrays or class objects, not int[]'s" and this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend inverting the condition:
if (!narg)
{
// ...
return setError();
}
// Code without elseThis makes the code more readable, as you get the error cases "out of the way".
src/dmd/expressionsem.d
Outdated
| else | ||
| { | ||
| // https://issues.dlang.org/show_bug.cgi?id=20422 | ||
| // Without this check the compiler would give a missleading error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misleading
…ic arrays or class objects, not int[]'s"
Done! Thanks for the suggestion! |
No description provided.