Fix Issue 21058 - __traits(getOverloads) forgets "this" with third ar…

[rmanthorpe]

…gument or if first overload is a template

[dlang-bot]

Thanks for your pull request and interest in making D better, @rmanthorpe! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	21058	normal	__traits(getOverloads) forgets "this" with third argument or if first overload is a template

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11432"

[UplinkCoder]

can you do it without changing the name e to exp ?

[rmanthorpe]

The local e was shadowing another e. Is it a problem? I can just rearrange to put more into the if(fd) block.

[UplinkCoder]

Looks good to me.
Except for one comment I made.

[UplinkCoder]

very nice and small now

[ghost]

Thanks for this bugfix @rmanthorpe, just one thing is that for small fixups to the main commit you should rather amend, but the "auto-merge-squash" label should have more or less the same effect.

[rmanthorpe]

Thanks @NilsLankila I'll bear that in mind in the future!