Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 14458 - very slow ubyte[] assignment (dmd doesn't use memset) #11437

Merged
merged 1 commit into from Jul 21, 2020

Conversation

WalterBright
Copy link
Member

This should be about 4 to 8 times faster for larger byte counts.

Do OPmemcmp separately. Not going to do OPstrcpy or OPstrcmp as they are never generated by DMD.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
14458 normal very slow ubyte[] assignment (dmd doesn't use memset)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11437"

@WalterBright
Copy link
Member Author

@MartinNowak fyi

@dlang-bot dlang-bot merged commit f86c9dc into dlang:master Jul 21, 2020
@WalterBright WalterBright deleted the fix14458 branch July 21, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants