Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21063 - getLinkage fails with forward references #11438

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jul 21, 2020

Use the same code as other traits, e.g. getClassInstanceSize, use.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 21, 2020

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
21063 regression getLinkage is wrong for forward reference extern(C++) class

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11438"

@thewilsonator
Copy link
Contributor

Stable?

@Geod24
Copy link
Member Author

Geod24 commented Jul 21, 2020

Yeah it's not really a regression (it never worked according to run.dlang.org) but will rebase anyway.

@Geod24 Geod24 changed the base branch from master to stable July 21, 2020 08:10
Use the same code as other traits, e.g. getClassInstanceSize, use.
@Geod24
Copy link
Member Author

Geod24 commented Jul 21, 2020

Green

@dlang-bot dlang-bot merged commit 0032771 into dlang:stable Jul 22, 2020
@Geod24 Geod24 deleted the mike-bug branch July 22, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants