Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 15103 - Improve declaration / initialization syntax error message #11477

Merged
merged 1 commit into from Jul 31, 2020

Conversation

adelavais
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @adelavais! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15103 minor Improve declaration / initialization syntax error message

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11477"

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

src/dmd/parse.d Outdated Show resolved Hide resolved
src/dmd/parse.d Outdated Show resolved Hide resolved
src/dmd/parse.d Outdated Show resolved Hide resolved
@RazvanN7
Copy link
Contributor

Please squash the commits and address Nils's comment and we are good to go.

@adelavais
Copy link
Contributor Author

Please squash the commits and address Nils's comment and we are good to go.

The above is my attempt to squash. Sorry about that. Will redo.

src/dmd/parse.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit 4c7e8be into dlang:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants