fix Issue 10966 - Optimizer generates wrong code with try-catch

[WalterBright]

2 line fix.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	10966	blocker	Optimizer generates wrong code with try-catch

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

To target stable perform these two steps:

1. Rebase your branch to upstream/stable:

git rebase --onto upstream/stable upstream/master

2. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11541"

[thewilsonator]

Stable.

[WalterBright]

It's a 7 year old bug.

[ghost]

There is a need for official rules on when it is required to target stable or master. In the meantime let's take this as-is

[MoonlightSentinel]

There are official rules ... but they get ignored again and again like this.

[Geod24]

Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

I mean the bug even write it. EVERY. TIME.

[ghost]

"should" VS "must" or "have to"

[ghost]

"it's mandatory for a .... to target the stable branch".

[wilzbach]

There is a need for official rules on when it is required to target stable or master. In the meantime let's take this as-is

There are official rules - https://wiki.dlang.org/DIP75#Branching_strategy
It's right in there:

TL;DR Safe fixes should always go into stable, all the time.

That's why there are so many ⚠️⚠️⚠️ in the automated bot message.

We stopped merging Walter's PRs in the past until they are targeting stable and that actually worked for a while.
It's literally just a one-line command to rebase to stable and the bot even tells one how to.

[ghost]

as we are collaborating on a compiler people have to take care of the semantics. "should" denotes something optional. It does not constitute a rule that a community has to follow. "should" is a gentle and polite invitation but leaves the door opened.

[ghost]

let's discuss and put it in the contribution guidlines.

[WalterBright]

Changes always come with a risk, meaning "stable" can become destabilized. With ancient bugs, there isn't a critical need to put the fix into stable, making me reluctant to risk the instability. Especially things like changing the optimizer, which always has risk to it.