fix Issue 16400 - naked variadic C function emits broken prologue #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#11550" |
|
This seems like this should target stable. |
ghost
approved these changes
Aug 11, 2020
ghost
added
ghost
requested review from
Geod24,
ibuclaw,
jacob-carlborg,
MartinNowak,
rainers,
RazvanN7 and
UplinkCoder
as code owners
ghost
removed request for
MartinNowak,
jacob-carlborg,
ibuclaw,
rainers,
Geod24,
UplinkCoder and
RazvanN7
UplinkCoder
reviewed
Aug 11, 2020
| if (funcsym_p.ty() & mTYnaked) | ||
| { // do not generate prolog | ||
| el_free(e); | ||
| e = el_long(TYint, 0); |
There was a problem hiding this comment.
this is a 0 literal, no?
why is it needed?
There was a problem hiding this comment.
I'm 99% sure that this is a kind of noop, as when using the elxxx table there's always an elem expected as result, but later it's eliminated. I want to learn a bit the backend, a confirmation would be nice.
Also look at elinfo(), same trick already used.
|
@NilsLankila I am not sure if this is ready yet? |
|
this is ready to me ;) |
|
This codegen bug is still not targeting stable... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.