Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21154 - DWARF: shared types are not represented #11568

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented Aug 13, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21154 minor DWARF: shared types are not represented

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11568"

@MoonlightSentinel
Copy link
Contributor

Tests?

@Luhrel
Copy link
Contributor Author

Luhrel commented Aug 13, 2020

Tests?

Unfortunately, there's no way to test this, because DMD doesn't emit the debug_pubtypes section.

@wilzbach
Copy link
Member

Unfortunately, there's no way to test this, because DMD doesn't emit the debug_pubtypes section.

Not even with a GDB or shell test?

@ibuclaw
Copy link
Member

ibuclaw commented Aug 13, 2020

Unfortunately, there's no way to test this, because DMD doesn't emit the debug_pubtypes section.

Not even with a GDB or shell test?

GDB ignores the tag, someone will have to implement support there as well...

... however, granted that this tag is intended for UPC, are we certain that it has the same meaning as D shared?

@Luhrel
Copy link
Contributor Author

Luhrel commented Aug 13, 2020

... however, granted that this tag is intended for UPC, are we certain that it has the same meaning as D shared?

Yes and no. DWARF tags are abstracts, so it'll depend of its implementation in the debuggers.

@dlang-bot dlang-bot merged commit 456a6de into dlang:master Aug 28, 2020
@Luhrel Luhrel deleted the fix21154 branch August 28, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants