Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 12832 - asm movdqu accepts wrong operand size #11570

Merged
1 commit merged into from
Aug 19, 2020

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright
Copy link
Member Author

Blocked by dlang/druntime#3194

There may be more.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
12832 normal asm movdqu accepts wrong operand size

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11570"

@Geod24
Copy link
Member

Geod24 commented Aug 15, 2020

Test?

@WalterBright
Copy link
Member Author

Currently blocked by dlang/phobos#7597

@WalterBright WalterBright force-pushed the fix12832 branch 8 times, most recently from 903713f to 69bdac3 Compare August 19, 2020 07:26
@ghost ghost removed the Merge:Blocked label Aug 19, 2020
@WalterBright
Copy link
Member Author

What's this from semaphoreci ?

+ generated/linux/release/64/dmd -version=NoBackend -version=GC -version=NoMain -Jgenerated/dub -Jsrc/dmd/res -Isrc -i -run test/dub_package/frontend.d
Error: program killed by signal 11

@ghost
Copy link

ghost commented Aug 19, 2020

No idea, I got the same crash for #11573 too. That PR was so simple that the failure is definitively from the side of the service not DMD, otherwise it would manifest in the Auto-Tester and circle-ci as well.

Note that you can try the same command localy (after a $ dub build) and verify that it works, as I just did.

$ generated/linux/release/64/dmd -version=NoBackend -version=GC -version=NoMain -Jgenerated/dub -Jsrc/dmd/res -Isrc -i -run test/dub_package/frontend.d
$ echo $?
0

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Aug 19, 2020

What's this from semaphoreci ?

That's unrelated, currently debugging in #11593

No idea, I got the same crash for #11573 too. That PR was so simple that the failure is definitively from the side of the service not DMD, otherwise it would manifest in the Auto-Tester and circle-ci as well.

Neither of those runs the dub package test. I guess it's related to the previous -lowmem issue because dub-package/frontend.d runs the frontend with enabled GC.

@WalterBright
Copy link
Member Author

@NilsLankila @MoonlightSentinel thanks for the information and work to track down that problem. Since it is unrelated to this PR, can we get this one pulled?

@ghost ghost added the Merge:auto-merge label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Auto-merge toggled on

@ghost ghost merged commit 9787142 into dlang:master Aug 19, 2020
@WalterBright
Copy link
Member Author

Thanks, guys!

@WalterBright WalterBright deleted the fix12832 branch August 19, 2020 23:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants