Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 15257 - __traits(compiles, .) with malformed inline asm sil… #11597

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

WalterBright
Copy link
Member

…ently ends compilation

Previous PRs for this:

#5244
#6068

@WalterBright WalterBright added the Review:WIP Work In Progress - not ready for review or pulling label Aug 20, 2020
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
15257 normal __traits(compiles, …) with malformed inline asm silently ends compilation

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11597"

@thewilsonator
Copy link
Contributor

Tests?

@WalterBright WalterBright force-pushed the fix15257 branch 2 times, most recently from a9211c1 to ed8fb30 Compare August 20, 2020 08:18
@WalterBright
Copy link
Member Author

circleci fails with:

Makefile:208: recipe for target 'start_all_tests' failed
make: *** [start_all_tests] Hangup
Too long with no output (exceeded 10m0s): context deadline exceeded

which is quite useless as it runs a thousand tests in parallel and there's no clue which it is.

@WalterBright
Copy link
Member Author

The timeout is happening on the autotester, too. But also with no clue in the log file.

@WalterBright WalterBright force-pushed the fix15257 branch 3 times, most recently from 46788be to ccc7b4c Compare August 20, 2020 09:22
@WalterBright
Copy link
Member Author

Found the loop, will fix it tomorrow. The problem is the old method didn't require any error recovery, which I have to add.

@WalterBright WalterBright force-pushed the fix15257 branch 2 times, most recently from fcc0b0c to 73fb708 Compare August 20, 2020 23:52
@WalterBright WalterBright removed the Review:WIP Work In Progress - not ready for review or pulling label Aug 21, 2020
@WalterBright WalterBright merged commit 9cb3a52 into dlang:master Aug 21, 2020
@WalterBright WalterBright deleted the fix15257 branch August 21, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants