Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21159 - DWARF: DW_AT_pure should be emitted for pure functions #11616

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented Aug 24, 2020

A subprogram entry may have a DW_AT_pure attribute, which is a flag. The
attribute indicates whether the subroutine was declared with the “pure”
keyword or property.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21159 enhancement DWARF: DW_AT_pure should be emitted for pure functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11616"

@thewilsonator
Copy link
Contributor

This seems to not work on freebsd.

@Luhrel Luhrel closed this Aug 25, 2020
@Luhrel Luhrel reopened this Aug 25, 2020
@Luhrel
Copy link
Contributor Author

Luhrel commented Aug 25, 2020

Objdump is too old on the FreeBSD machines.

Unknown AT value: 67: 1

@Luhrel Luhrel force-pushed the fix21159 branch 3 times, most recently from a8c02ab to dd683be Compare August 25, 2020 09:45
@Geod24
Copy link
Member

Geod24 commented Aug 25, 2020

@braddr : Any chance we could get some of those machines upgraded ? Not only the FreeBSD, but the auto-tester in general. AFAIK it's been quite a while.
@jmdavis : You are the only FreeBSD user I know, any advice / previous experience with this ?

test/dshell/dwarf.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit 4028c58 into dlang:master Aug 26, 2020
@Luhrel Luhrel deleted the fix21159 branch August 26, 2020 12:16
@nordlow
Copy link
Contributor

nordlow commented Aug 26, 2020

Are there any functional benefits to this other than better diagnostics for tools such as gdb that can read and present dwarf information?

@Luhrel
Copy link
Contributor Author

Luhrel commented Aug 26, 2020

Are there any functional benefits to this other than better diagnostics for tools such as gdb that can read and present dwarf information?

Nope. Real benefits depend on the dwarf consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants