-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 21208 - C/C++ header generation for {string,enum} enums #11642
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11642" |
|
Could you add a test for: struct Foo { int i; }
enum MyEnum { A = Foo(42), B = Foo(84) }Otherwise LGTM |
Sure. Added. |
|
@thewilsonator FYI: I added another test to cover both cases |
|
I'll leave merging to you then. |
| ENUM_CONSTANT(STC, STC_D, (STC)3) | ||
|
|
||
| // ignoring non-cpp struct Foo because of linkage | ||
| BEGIN_ENUM_TYPE(Foo, MyEnum, MYENUM, myenum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make much sense, but I added it to check that there's at least no segfault.
Split-off from #11575