Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21120 - Inconsistent mangling of __init symbol #11645

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Aug 29, 2020

The mangling code previously assumed no identifier would ever start at buffer offset 0. Get rid of that assumption by storing offset+1.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 29, 2020

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21120 major Inconsistent mangling of __init symbol

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11645"

@thewilsonator
Copy link
Contributor

Please target stable.

@kinke kinke requested review from Geod24 and ibuclaw as code owners August 29, 2020 15:09
@kinke kinke changed the base branch from master to stable August 29, 2020 15:10
@kinke kinke force-pushed the fix21120 branch 2 times, most recently from 7695fce to e48180d Compare August 29, 2020 15:34
The mangling code previously assumed no identifier would ever start at
buffer offset 0. Get rid of that assumption by storing offset+1.
@dlang-bot dlang-bot merged commit 28c0276 into dlang:stable Aug 29, 2020
@kinke kinke deleted the fix21120 branch August 29, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants