Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20934 - preview=dtorfields segfaults for disabled/extern construc… #11658

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

…tors

Don't try to insert a destructor body if there's no body because
the following semantic would segfault due to the missing try-block

Extracted from #11656

…tors

Don't try to insert a destructor body if there's no body because
the following semantic would segfault due to the missing try-block
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20934 normal preview=dtorfields segfaults for disabled/extern constructors

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11658"

@dlang-bot dlang-bot merged commit 3ef6c37 into dlang:master Sep 1, 2020
@MoonlightSentinel MoonlightSentinel deleted the dtorfield-segfault branch April 3, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants