Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 16317 - Wrong binop evaluation/load order when optimizing #11684

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

WalterBright
Copy link
Member

This also wound up converting tabs to spaces in mars1.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
16317 critical Wrong binop evaluation/load order when optimizing

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11684"

@WalterBright
Copy link
Member Author

More heisenbugs, this time in buildkite/dmd/build:

  | Preparing working directory | 3s
  | -- | --
  | Running commands | 0s
  | Print environment | 0s
  | Load CI folder | 0s
  | Merging with the upstream target branch | 2s
  | Setting build variables | 0s
  | Setting build variables | 0s
  | Cloning all core repositories | 11s
  | Building dmd |  
  | ~> dmd/src/bootstrap.sh
  | [boostrap] Downloading compiler http://downloads.dlang.org/releases/2.x/2.088.0/dmd.2.088.0.linux.tar.xz

Note no useful information.

@ghost ghost added the Merge:auto-merge label Sep 6, 2020
@dlang-bot dlang-bot merged commit fa74337 into dlang:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants