fix Issue 19384 - [Codegen] Address of stack temporary is returned #11701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
WalterBright
force-pushed
the
fix19384
branch
from
95b619a to
d7ec2bd
Compare
thewilsonator
approved these changes
Sep 7, 2020
WalterBright
force-pushed
the
fix19384
branch
from
d7ec2bd to
d8d294f
Compare
|
It's marked as critical, but has been there for probably 15 years. It's an ugly bug, but pretty hard to trigger. |
UplinkCoder
reviewed
Sep 7, 2020
|
@WalterBright why the self merge? |
|
How does this fix work? |
John-Colvin
reviewed
Sep 7, 2020
| if (ve.var == func.vresult) | ||
| goto Lskip; | ||
| } | ||
| } |
There was a problem hiding this comment.
this is the best advert for a ?. operator or similar I've seen in a while.
if (s.exp.isBklitExp()?.e1.isVarExp()?.var == func.vresult)
goto Lskip;
There was a problem hiding this comment.
regardless of ?.
Even when stated in one line I am still not sure what this actually matches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.