fix Issue 20716 - Wrong code/ABI for extern(C++) interface method tha… #11703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11703" |
WalterBright
force-pushed
the
fix20716
branch
4 times, most recently
from
f04f117 to
4bcd416
Compare
|
This is ready to go. |
|
The commit message is too short. |
|
@WalterBright This should be part of the commit message: |
|
Stable. |
RazvanN7
approved these changes
Sep 23, 2020
| @@ -4719,6 +4719,8 @@ void cod3_thunk(Symbol *sthunk,Symbol *sfunc,uint p,tym_t thisty, | |||
| p += I32 ? 8 : tysize(TYfptr); // far function | |||
| else | |||
| p += tysize(TYnptr); | |||
| if (tybasic(sfunc.ty()) == TYhfunc) | |||
| p += tysize(TYnptr); // skip over hidden pointer | |||
There was a problem hiding this comment.
This line appears to not be covered by tests.
…t returns non-POD
WalterBright
force-pushed
the
fix20716
branch
from
4bcd416 to
9ad79f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t returns non-POD