fix Issue 20688 - Wrong code when linking to C complex number functions #11710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11710" |
wilzbach
reviewed
Sep 7, 2020
test/runnable/complex.d
Outdated
| cdouble r = cpowf(2. + 0i, 2. + 0i); | ||
| assert(cast(double)creal(r) == 4.0); | ||
| assert(cast(double)cimag(r) == 0.0); | ||
| printf("%f+%fi\n", cast(double)creal(r), cast(double)cimag(r)); |
There was a problem hiding this comment.
You can use RUN_OUTPUT to check the output for correctness.
There was a problem hiding this comment.
Or remove the printf as we're already covered by asserts?
There was a problem hiding this comment.
The printf is nice to save typing when it doesn't work.
WalterBright
force-pushed
the
fix20688
branch
2 times, most recently
from
be5ef3f to
469b35f
Compare
|
Didn't l fix this months ago? |
I don't see how, as it is failing on some platforms! |
|
See #12073, which tests all complex types on all extern linkages. |
|
Ahh, you're testing Windows. I didn't think that they had complex types. |
WalterBright
force-pushed
the
fix20688
branch
from
13128b6 to
6d6823e
Compare
WalterBright
force-pushed
the
fix20688
branch
from
6d6823e to
3561277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settle dispute over whether it works or not :-)