Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 15909 - Duplicate case error reports characters as numbers #11716

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

Luhrel
Copy link
Contributor

@Luhrel Luhrel commented Sep 9, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15909 trivial Duplicate case error reports characters as numbers

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11716"

src/dmd/statementsem.d Outdated Show resolved Hide resolved
@Luhrel Luhrel force-pushed the fix15909 branch 2 times, most recently from fe6af70 to ea6b387 Compare September 10, 2020 20:57
@Luhrel
Copy link
Contributor Author

Luhrel commented Sep 10, 2020

The problem was that the CaseSatement is casted to the type of the expression in the switch statement, which is promoted as an integer via integralPromotions.

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/dmd/statementsem.d Outdated Show resolved Hide resolved
@MoonlightSentinel
Copy link
Contributor

Rebased it for you, that should make BuildKite pass again.

@dlang-bot dlang-bot merged commit ccf2c7f into dlang:stable Sep 27, 2020
@Luhrel
Copy link
Contributor Author

Luhrel commented Oct 3, 2020

Rebased it for you, that should make BuildKite pass again.

Oh, thanks !

@Luhrel Luhrel deleted the fix15909 branch January 1, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants